Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unruly r1 consolidated adapter #3054

Merged
merged 4 commits into from
Jul 1, 2021

Conversation

tallavon
Copy link
Contributor

Updating the unruly adapter params and supported features according to the consolidated adapter with rhythm one adapter and unruly adapter.

Copy link
Contributor

@bretg bretg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the rhythmone adapter will stay around?

Because prebid.org docs cover multiple versions, I recommend leaving your targetingUUID parameter in the table with a note that says something like "required before PBJS 5.x" and featureOverrides to "optional after PBJS 5.x". This way pubs using older versions of PBJS and your adapter are less likely to make errors.

@bretg bretg added the question label Jun 23, 2021
@tallavon
Copy link
Contributor Author

Yes, the rhythmone adapter will stay as it is.
We will return the targetingUUID parameter with a note as you suggested.
About the featureOverrides parameter it's supported in older versions too but the documentation was not updated correctly.

…to bid params as requested from prebid reviewer.
@tallavon
Copy link
Contributor Author

tallavon commented Jul 1, 2021

After further discussion with the team we realised there is no need for the targetingUUID parameter even in the legacy Unruly adapter. Pubs that use the old adapter are no longer required to provide this param, so we going to remove it from the Bid Params table.

…ause it's no longer needed for the old adapter.
@jeanstemp jeanstemp merged commit 20abad8 into prebid:master Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants